Simulation of a banking system with an Account class in C++ The 2019 Stack Overflow Developer...

Who or what is the being for whom Being is a question for Heidegger?

How is simplicity better than precision and clarity in prose?

Working through the single responsibility principle (SRP) in Python when calls are expensive

How to delete random line from file using Unix command?

How to copy the contents of all files with a certain name into a new file?

What information about me do stores get via my credit card?

When did F become S in typeography, and why?

What can I do if neighbor is blocking my solar panels intentionally?

Windows 10: How to Lock (not sleep) laptop on lid close?

ELI5: Why do they say that Israel would have been the fourth country to land a spacecraft on the Moon and why do they call it low cost?

Simulation of a banking system with an Account class in C++

Is this wall load bearing? Blueprints and photos attached

Why does the Event Horizon Telescope (EHT) not include telescopes from Africa, Asia or Australia?

Create an outline of font

What aspect of planet Earth must be changed to prevent the industrial revolution?

Python - Fishing Simulator

Scientific Reports - Significant Figures

Sort a list of pairs representing an acyclic, partial automorphism

Searching for a differential characteristic (differential cryptanalysis)

Are my PIs rude or am I just being too sensitive?

Why did all the guest students take carriages to the Yule Ball?

Do warforged have souls?

does high air pressure throw off wheel balance?

Why is superheterodyning better than direct conversion?



Simulation of a banking system with an Account class in C++



The 2019 Stack Overflow Developer Survey Results Are In
Announcing the arrival of Valued Associate #679: Cesar Manara
Planned maintenance scheduled April 17/18, 2019 at 00:00UTC (8:00pm US/Eastern)Simple container class with templatesOOP bank databaseUsing PostgreSQL effectively with a banking appAccount registration system for a quiz gameFake bank account classBanking system programRuby banking system programCinema SimulationAn account/banking system in C++C++ Banking Class





.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty,.everyoneloves__bot-mid-leaderboard:empty{ margin-bottom:0;
}







3












$begingroup$


I have been learning C++ and recently I have started practicing classes. I made this simulation of a banking system with an Account class. I would like to hear feedback on my code, what is good - what I should keep doing, and especially what I should pay more attention to, or if you have any suggestion on how to simplify parts of the code, make it more readable because I feel this could be improved. Also, I would like to hear comments on exception handling, since I am quite new to that as well. Thank you all in advance, I will do my best to implement any of your suggestions.



Account.h



#ifndef ACCOUNT.H
#define ACCOUNT.H
#include <string>
#include <vector>

class Account{
std::string name;
int id;
double balance;

public:
Account();
std::string getName() const;
int getId() const;
double getBalance() const;
void setName(std::string);
void setID(int);
void setBalance(double);
void addAccount (Account);
void withdraw(double);
void deposit(double);

static std::vector<Account> accountDatabase;
};
#endif // ACCOUNT


Account.cpp



#include "Account.h"
#include <iostream>
#include <string>
#include <vector>

Account::Account(){
name = "";
id = 0;
balance = 0;
}

std::vector<Account> Account::accountDatabase;

void Account::addAccount(Account account){
accountDatabase.push_back(account);
}

std::string Account::getName() const{
return name;
}

int Account::getId() const{
return id;
}

double Account::getBalance() const{
return balance;
}

void Account::setName(std::string userName){
name = userName;
}

void Account::setID(int newId){
if (newId < 1)
throw "ntttt ~ ID cannot be zero or negative ~";

for (int i = 0; i < accountDatabase.size(); i++)
if (newId == accountDatabase[i].getId())
throw "ntttt~ Entered ID is already in use ~";

id = newId;
}

void Account::setBalance(double newBalance){
if (newBalance < 0)
throw "ntttt ~ Balance cannot be negative ~";

balance = newBalance;
}

void Account::withdraw(double amount){
if (amount < 0)
throw "ntttt ~ Withdrawal amount cannot be negative ~";

balance -= amount;
}

void Account::deposit(double amount){
if (amount < 0)
throw "ntttt ~ Amount for deposit cannot be negative ~";

balance += amount;
}


Main



#include <iostream>
#include "Account.h"
#include <string>

void printMenu(){
std::cout << "n" << R"(
Please select one of the following options:

1. Create an account
2. Check balance
3. Withdraw
4. Deposit
5. Account summary
6. Make a transaction
7. Exit
)" << "ntttt--> ";
}

// get a valid input
template<typename Type>
void getInput(Type &value){
while (true){
std::cin >> value;
if (std::cin.fail()){
std::cin.clear();
std::cin.ignore(100, 'n');
std::cout << "nttttt~ Invalid input ~"
<< "ntttt--> Enter again: ";
}
else {
std::cin.ignore();
return;
}
}
}

// find account in account database and return index of that account
int findAccount (int id){
for (int i = 0; i < Account::accountDatabase.size(); i++)
if (id == Account::accountDatabase[i].getId()) return i;

return -1;
}

void createAccount (){
Account newAccount;
std::cout << "ntttt--> Please enter your name: ";
std::string name;
std::cin.ignore();
std::getline(std::cin, name);
newAccount.setName(name);
std::cout << "ntttt--> Please enter your ID: ";
int id;
getInput(id);
newAccount.setID(id);
std::cout << "ntttt--> Please enter your balance: ";
double balance;
getInput(balance);
newAccount.setBalance(balance);
// add account to the database
newAccount.addAccount(newAccount);
std::cout << "ntttt~ Your account has been successfully created ~n";
}

void MenuSelection(){

int option = 1, account, id;
while (option != 7){

try{
switch (option){
case 1: createAccount();break;

// check balance
case 2:{
std::cout << "ntttt--> Please enter your ID: ";
getInput(id);
account = findAccount(id);
if (account == -1) std::cout << "ntttt~ ID does not match any in the database ~n";
else std::cout << "ntttt--> Your balance: " << Account::accountDatabase[account].getBalance();
} break;

// withdraw money
case 3:{
std::cout << "ntttt--> Enter amount to withdraw: ";
double withdrawalAmount;
getInput(withdrawalAmount);
std::cout << "ntttt--> Please enter your ID: ";
getInput(id);
account = findAccount(id);
if (account == -1) std::cout << "ntttt~ ID does not match any in the database ~n";
else {
if (Account::accountDatabase[account].getBalance() >= withdrawalAmount){
Account::accountDatabase[account].withdraw(withdrawalAmount);
std::cout << "ntttt~ Amount successfully withdrawn ~n";
}
else std::cout << "nttt~ Withdrawal not successful - check the state of balance ~n";
}
} break;

// deposit money
case 4:{
std::cout << "ntttt--> Enter amount to deposit: ";
double depositAmount;
getInput(depositAmount);
std::cout << "ntttt--> Please enter your ID: ";
getInput(id);
account = findAccount(id);
if (account == -1) std::cout << "ntttt~ ID does not match any in the database ~n";
else {
Account::accountDatabase[account].deposit(depositAmount);
std::cout << "ntttt-->~ Amount successfully deposited ~n";
}
} break;

// print account summary
case 5:{
std::cout << "ntttt--> Please enter your ID: ";
getInput(id);
account = findAccount(id);
if (account == -1) std::cout << "ntttt~ ID does not match any in the database ~n";
else std::cout << "nntttt~ ACCOUNT SUMMARY ~n"
<< "ntttt--> Name: " << Account::accountDatabase[account].getName()
<< "ntttt--> ID: " << Account::accountDatabase[account].getId()
<< "ntttt--> Balance: " << Account::accountDatabase[account].getBalance() << "n";

} break;

// make a transaction
case 6:{
std::cout << "ntttt--> Do you wish to withdraw or deposit? (w/d): ";
char choice;
std::cin >> choice;
std::cout << "ntttt--> Enter transaction amount: ";
double amount;
getInput(amount);
std::cout << "ntttt--> Please enter your ID: ";
getInput(id);
account = findAccount(id);
if (account == -1) std::cout << "ntttt~ ID does not match any in the database ~n";
else {
std::cout << "ntttt--> Please enter ID of the transaction account: ";
getInput(id);
int secondAccount = findAccount(id);
if (secondAccount == -1) std::cout << "ntttt~ ID does not match any in the database ~n";
else {
bool transactionPerformed = false;
if (tolower(choice) == 'w' && Account::accountDatabase[secondAccount].getBalance() >= amount){
Account::accountDatabase[secondAccount].withdraw(amount);
Account::accountDatabase[account].deposit(amount);
transactionPerformed = true;
}
else if (tolower(choice) == 'd' && Account::accountDatabase[account].getBalance() >= amount){
Account::accountDatabase[secondAccount].deposit(amount);
Account::accountDatabase[account].withdraw(amount);
transactionPerformed = true;
}
if (!transactionPerformed) std::cout << "ntttt~ Transaction not successful ~n";
else std::cout << "ntttt~ Transaction successfully completed ~n";
}
}
}
}
}
catch (const char* msg){
std::cerr << msg;
}
printMenu();
getInput(option);
while (option < 1 || option > 7){
std::cout << "ntttt--> Please enter a valid option (1-7): ";
getInput(option);
}
}

std::cout << R"(
########################################################################################################################
~ THANK YOU FOR USING OUR SERVICES ~

########################################################################################################################
)";
}

int main(){
std::cout << R"(
########################################################################################################################
~ W E L C O M E T O O U R B A N K ~

########################################################################################################################


)";
MenuSelection();
return 0;
}









share|improve this question









$endgroup$



















    3












    $begingroup$


    I have been learning C++ and recently I have started practicing classes. I made this simulation of a banking system with an Account class. I would like to hear feedback on my code, what is good - what I should keep doing, and especially what I should pay more attention to, or if you have any suggestion on how to simplify parts of the code, make it more readable because I feel this could be improved. Also, I would like to hear comments on exception handling, since I am quite new to that as well. Thank you all in advance, I will do my best to implement any of your suggestions.



    Account.h



    #ifndef ACCOUNT.H
    #define ACCOUNT.H
    #include <string>
    #include <vector>

    class Account{
    std::string name;
    int id;
    double balance;

    public:
    Account();
    std::string getName() const;
    int getId() const;
    double getBalance() const;
    void setName(std::string);
    void setID(int);
    void setBalance(double);
    void addAccount (Account);
    void withdraw(double);
    void deposit(double);

    static std::vector<Account> accountDatabase;
    };
    #endif // ACCOUNT


    Account.cpp



    #include "Account.h"
    #include <iostream>
    #include <string>
    #include <vector>

    Account::Account(){
    name = "";
    id = 0;
    balance = 0;
    }

    std::vector<Account> Account::accountDatabase;

    void Account::addAccount(Account account){
    accountDatabase.push_back(account);
    }

    std::string Account::getName() const{
    return name;
    }

    int Account::getId() const{
    return id;
    }

    double Account::getBalance() const{
    return balance;
    }

    void Account::setName(std::string userName){
    name = userName;
    }

    void Account::setID(int newId){
    if (newId < 1)
    throw "ntttt ~ ID cannot be zero or negative ~";

    for (int i = 0; i < accountDatabase.size(); i++)
    if (newId == accountDatabase[i].getId())
    throw "ntttt~ Entered ID is already in use ~";

    id = newId;
    }

    void Account::setBalance(double newBalance){
    if (newBalance < 0)
    throw "ntttt ~ Balance cannot be negative ~";

    balance = newBalance;
    }

    void Account::withdraw(double amount){
    if (amount < 0)
    throw "ntttt ~ Withdrawal amount cannot be negative ~";

    balance -= amount;
    }

    void Account::deposit(double amount){
    if (amount < 0)
    throw "ntttt ~ Amount for deposit cannot be negative ~";

    balance += amount;
    }


    Main



    #include <iostream>
    #include "Account.h"
    #include <string>

    void printMenu(){
    std::cout << "n" << R"(
    Please select one of the following options:

    1. Create an account
    2. Check balance
    3. Withdraw
    4. Deposit
    5. Account summary
    6. Make a transaction
    7. Exit
    )" << "ntttt--> ";
    }

    // get a valid input
    template<typename Type>
    void getInput(Type &value){
    while (true){
    std::cin >> value;
    if (std::cin.fail()){
    std::cin.clear();
    std::cin.ignore(100, 'n');
    std::cout << "nttttt~ Invalid input ~"
    << "ntttt--> Enter again: ";
    }
    else {
    std::cin.ignore();
    return;
    }
    }
    }

    // find account in account database and return index of that account
    int findAccount (int id){
    for (int i = 0; i < Account::accountDatabase.size(); i++)
    if (id == Account::accountDatabase[i].getId()) return i;

    return -1;
    }

    void createAccount (){
    Account newAccount;
    std::cout << "ntttt--> Please enter your name: ";
    std::string name;
    std::cin.ignore();
    std::getline(std::cin, name);
    newAccount.setName(name);
    std::cout << "ntttt--> Please enter your ID: ";
    int id;
    getInput(id);
    newAccount.setID(id);
    std::cout << "ntttt--> Please enter your balance: ";
    double balance;
    getInput(balance);
    newAccount.setBalance(balance);
    // add account to the database
    newAccount.addAccount(newAccount);
    std::cout << "ntttt~ Your account has been successfully created ~n";
    }

    void MenuSelection(){

    int option = 1, account, id;
    while (option != 7){

    try{
    switch (option){
    case 1: createAccount();break;

    // check balance
    case 2:{
    std::cout << "ntttt--> Please enter your ID: ";
    getInput(id);
    account = findAccount(id);
    if (account == -1) std::cout << "ntttt~ ID does not match any in the database ~n";
    else std::cout << "ntttt--> Your balance: " << Account::accountDatabase[account].getBalance();
    } break;

    // withdraw money
    case 3:{
    std::cout << "ntttt--> Enter amount to withdraw: ";
    double withdrawalAmount;
    getInput(withdrawalAmount);
    std::cout << "ntttt--> Please enter your ID: ";
    getInput(id);
    account = findAccount(id);
    if (account == -1) std::cout << "ntttt~ ID does not match any in the database ~n";
    else {
    if (Account::accountDatabase[account].getBalance() >= withdrawalAmount){
    Account::accountDatabase[account].withdraw(withdrawalAmount);
    std::cout << "ntttt~ Amount successfully withdrawn ~n";
    }
    else std::cout << "nttt~ Withdrawal not successful - check the state of balance ~n";
    }
    } break;

    // deposit money
    case 4:{
    std::cout << "ntttt--> Enter amount to deposit: ";
    double depositAmount;
    getInput(depositAmount);
    std::cout << "ntttt--> Please enter your ID: ";
    getInput(id);
    account = findAccount(id);
    if (account == -1) std::cout << "ntttt~ ID does not match any in the database ~n";
    else {
    Account::accountDatabase[account].deposit(depositAmount);
    std::cout << "ntttt-->~ Amount successfully deposited ~n";
    }
    } break;

    // print account summary
    case 5:{
    std::cout << "ntttt--> Please enter your ID: ";
    getInput(id);
    account = findAccount(id);
    if (account == -1) std::cout << "ntttt~ ID does not match any in the database ~n";
    else std::cout << "nntttt~ ACCOUNT SUMMARY ~n"
    << "ntttt--> Name: " << Account::accountDatabase[account].getName()
    << "ntttt--> ID: " << Account::accountDatabase[account].getId()
    << "ntttt--> Balance: " << Account::accountDatabase[account].getBalance() << "n";

    } break;

    // make a transaction
    case 6:{
    std::cout << "ntttt--> Do you wish to withdraw or deposit? (w/d): ";
    char choice;
    std::cin >> choice;
    std::cout << "ntttt--> Enter transaction amount: ";
    double amount;
    getInput(amount);
    std::cout << "ntttt--> Please enter your ID: ";
    getInput(id);
    account = findAccount(id);
    if (account == -1) std::cout << "ntttt~ ID does not match any in the database ~n";
    else {
    std::cout << "ntttt--> Please enter ID of the transaction account: ";
    getInput(id);
    int secondAccount = findAccount(id);
    if (secondAccount == -1) std::cout << "ntttt~ ID does not match any in the database ~n";
    else {
    bool transactionPerformed = false;
    if (tolower(choice) == 'w' && Account::accountDatabase[secondAccount].getBalance() >= amount){
    Account::accountDatabase[secondAccount].withdraw(amount);
    Account::accountDatabase[account].deposit(amount);
    transactionPerformed = true;
    }
    else if (tolower(choice) == 'd' && Account::accountDatabase[account].getBalance() >= amount){
    Account::accountDatabase[secondAccount].deposit(amount);
    Account::accountDatabase[account].withdraw(amount);
    transactionPerformed = true;
    }
    if (!transactionPerformed) std::cout << "ntttt~ Transaction not successful ~n";
    else std::cout << "ntttt~ Transaction successfully completed ~n";
    }
    }
    }
    }
    }
    catch (const char* msg){
    std::cerr << msg;
    }
    printMenu();
    getInput(option);
    while (option < 1 || option > 7){
    std::cout << "ntttt--> Please enter a valid option (1-7): ";
    getInput(option);
    }
    }

    std::cout << R"(
    ########################################################################################################################
    ~ THANK YOU FOR USING OUR SERVICES ~

    ########################################################################################################################
    )";
    }

    int main(){
    std::cout << R"(
    ########################################################################################################################
    ~ W E L C O M E T O O U R B A N K ~

    ########################################################################################################################


    )";
    MenuSelection();
    return 0;
    }









    share|improve this question









    $endgroup$















      3












      3








      3





      $begingroup$


      I have been learning C++ and recently I have started practicing classes. I made this simulation of a banking system with an Account class. I would like to hear feedback on my code, what is good - what I should keep doing, and especially what I should pay more attention to, or if you have any suggestion on how to simplify parts of the code, make it more readable because I feel this could be improved. Also, I would like to hear comments on exception handling, since I am quite new to that as well. Thank you all in advance, I will do my best to implement any of your suggestions.



      Account.h



      #ifndef ACCOUNT.H
      #define ACCOUNT.H
      #include <string>
      #include <vector>

      class Account{
      std::string name;
      int id;
      double balance;

      public:
      Account();
      std::string getName() const;
      int getId() const;
      double getBalance() const;
      void setName(std::string);
      void setID(int);
      void setBalance(double);
      void addAccount (Account);
      void withdraw(double);
      void deposit(double);

      static std::vector<Account> accountDatabase;
      };
      #endif // ACCOUNT


      Account.cpp



      #include "Account.h"
      #include <iostream>
      #include <string>
      #include <vector>

      Account::Account(){
      name = "";
      id = 0;
      balance = 0;
      }

      std::vector<Account> Account::accountDatabase;

      void Account::addAccount(Account account){
      accountDatabase.push_back(account);
      }

      std::string Account::getName() const{
      return name;
      }

      int Account::getId() const{
      return id;
      }

      double Account::getBalance() const{
      return balance;
      }

      void Account::setName(std::string userName){
      name = userName;
      }

      void Account::setID(int newId){
      if (newId < 1)
      throw "ntttt ~ ID cannot be zero or negative ~";

      for (int i = 0; i < accountDatabase.size(); i++)
      if (newId == accountDatabase[i].getId())
      throw "ntttt~ Entered ID is already in use ~";

      id = newId;
      }

      void Account::setBalance(double newBalance){
      if (newBalance < 0)
      throw "ntttt ~ Balance cannot be negative ~";

      balance = newBalance;
      }

      void Account::withdraw(double amount){
      if (amount < 0)
      throw "ntttt ~ Withdrawal amount cannot be negative ~";

      balance -= amount;
      }

      void Account::deposit(double amount){
      if (amount < 0)
      throw "ntttt ~ Amount for deposit cannot be negative ~";

      balance += amount;
      }


      Main



      #include <iostream>
      #include "Account.h"
      #include <string>

      void printMenu(){
      std::cout << "n" << R"(
      Please select one of the following options:

      1. Create an account
      2. Check balance
      3. Withdraw
      4. Deposit
      5. Account summary
      6. Make a transaction
      7. Exit
      )" << "ntttt--> ";
      }

      // get a valid input
      template<typename Type>
      void getInput(Type &value){
      while (true){
      std::cin >> value;
      if (std::cin.fail()){
      std::cin.clear();
      std::cin.ignore(100, 'n');
      std::cout << "nttttt~ Invalid input ~"
      << "ntttt--> Enter again: ";
      }
      else {
      std::cin.ignore();
      return;
      }
      }
      }

      // find account in account database and return index of that account
      int findAccount (int id){
      for (int i = 0; i < Account::accountDatabase.size(); i++)
      if (id == Account::accountDatabase[i].getId()) return i;

      return -1;
      }

      void createAccount (){
      Account newAccount;
      std::cout << "ntttt--> Please enter your name: ";
      std::string name;
      std::cin.ignore();
      std::getline(std::cin, name);
      newAccount.setName(name);
      std::cout << "ntttt--> Please enter your ID: ";
      int id;
      getInput(id);
      newAccount.setID(id);
      std::cout << "ntttt--> Please enter your balance: ";
      double balance;
      getInput(balance);
      newAccount.setBalance(balance);
      // add account to the database
      newAccount.addAccount(newAccount);
      std::cout << "ntttt~ Your account has been successfully created ~n";
      }

      void MenuSelection(){

      int option = 1, account, id;
      while (option != 7){

      try{
      switch (option){
      case 1: createAccount();break;

      // check balance
      case 2:{
      std::cout << "ntttt--> Please enter your ID: ";
      getInput(id);
      account = findAccount(id);
      if (account == -1) std::cout << "ntttt~ ID does not match any in the database ~n";
      else std::cout << "ntttt--> Your balance: " << Account::accountDatabase[account].getBalance();
      } break;

      // withdraw money
      case 3:{
      std::cout << "ntttt--> Enter amount to withdraw: ";
      double withdrawalAmount;
      getInput(withdrawalAmount);
      std::cout << "ntttt--> Please enter your ID: ";
      getInput(id);
      account = findAccount(id);
      if (account == -1) std::cout << "ntttt~ ID does not match any in the database ~n";
      else {
      if (Account::accountDatabase[account].getBalance() >= withdrawalAmount){
      Account::accountDatabase[account].withdraw(withdrawalAmount);
      std::cout << "ntttt~ Amount successfully withdrawn ~n";
      }
      else std::cout << "nttt~ Withdrawal not successful - check the state of balance ~n";
      }
      } break;

      // deposit money
      case 4:{
      std::cout << "ntttt--> Enter amount to deposit: ";
      double depositAmount;
      getInput(depositAmount);
      std::cout << "ntttt--> Please enter your ID: ";
      getInput(id);
      account = findAccount(id);
      if (account == -1) std::cout << "ntttt~ ID does not match any in the database ~n";
      else {
      Account::accountDatabase[account].deposit(depositAmount);
      std::cout << "ntttt-->~ Amount successfully deposited ~n";
      }
      } break;

      // print account summary
      case 5:{
      std::cout << "ntttt--> Please enter your ID: ";
      getInput(id);
      account = findAccount(id);
      if (account == -1) std::cout << "ntttt~ ID does not match any in the database ~n";
      else std::cout << "nntttt~ ACCOUNT SUMMARY ~n"
      << "ntttt--> Name: " << Account::accountDatabase[account].getName()
      << "ntttt--> ID: " << Account::accountDatabase[account].getId()
      << "ntttt--> Balance: " << Account::accountDatabase[account].getBalance() << "n";

      } break;

      // make a transaction
      case 6:{
      std::cout << "ntttt--> Do you wish to withdraw or deposit? (w/d): ";
      char choice;
      std::cin >> choice;
      std::cout << "ntttt--> Enter transaction amount: ";
      double amount;
      getInput(amount);
      std::cout << "ntttt--> Please enter your ID: ";
      getInput(id);
      account = findAccount(id);
      if (account == -1) std::cout << "ntttt~ ID does not match any in the database ~n";
      else {
      std::cout << "ntttt--> Please enter ID of the transaction account: ";
      getInput(id);
      int secondAccount = findAccount(id);
      if (secondAccount == -1) std::cout << "ntttt~ ID does not match any in the database ~n";
      else {
      bool transactionPerformed = false;
      if (tolower(choice) == 'w' && Account::accountDatabase[secondAccount].getBalance() >= amount){
      Account::accountDatabase[secondAccount].withdraw(amount);
      Account::accountDatabase[account].deposit(amount);
      transactionPerformed = true;
      }
      else if (tolower(choice) == 'd' && Account::accountDatabase[account].getBalance() >= amount){
      Account::accountDatabase[secondAccount].deposit(amount);
      Account::accountDatabase[account].withdraw(amount);
      transactionPerformed = true;
      }
      if (!transactionPerformed) std::cout << "ntttt~ Transaction not successful ~n";
      else std::cout << "ntttt~ Transaction successfully completed ~n";
      }
      }
      }
      }
      }
      catch (const char* msg){
      std::cerr << msg;
      }
      printMenu();
      getInput(option);
      while (option < 1 || option > 7){
      std::cout << "ntttt--> Please enter a valid option (1-7): ";
      getInput(option);
      }
      }

      std::cout << R"(
      ########################################################################################################################
      ~ THANK YOU FOR USING OUR SERVICES ~

      ########################################################################################################################
      )";
      }

      int main(){
      std::cout << R"(
      ########################################################################################################################
      ~ W E L C O M E T O O U R B A N K ~

      ########################################################################################################################


      )";
      MenuSelection();
      return 0;
      }









      share|improve this question









      $endgroup$




      I have been learning C++ and recently I have started practicing classes. I made this simulation of a banking system with an Account class. I would like to hear feedback on my code, what is good - what I should keep doing, and especially what I should pay more attention to, or if you have any suggestion on how to simplify parts of the code, make it more readable because I feel this could be improved. Also, I would like to hear comments on exception handling, since I am quite new to that as well. Thank you all in advance, I will do my best to implement any of your suggestions.



      Account.h



      #ifndef ACCOUNT.H
      #define ACCOUNT.H
      #include <string>
      #include <vector>

      class Account{
      std::string name;
      int id;
      double balance;

      public:
      Account();
      std::string getName() const;
      int getId() const;
      double getBalance() const;
      void setName(std::string);
      void setID(int);
      void setBalance(double);
      void addAccount (Account);
      void withdraw(double);
      void deposit(double);

      static std::vector<Account> accountDatabase;
      };
      #endif // ACCOUNT


      Account.cpp



      #include "Account.h"
      #include <iostream>
      #include <string>
      #include <vector>

      Account::Account(){
      name = "";
      id = 0;
      balance = 0;
      }

      std::vector<Account> Account::accountDatabase;

      void Account::addAccount(Account account){
      accountDatabase.push_back(account);
      }

      std::string Account::getName() const{
      return name;
      }

      int Account::getId() const{
      return id;
      }

      double Account::getBalance() const{
      return balance;
      }

      void Account::setName(std::string userName){
      name = userName;
      }

      void Account::setID(int newId){
      if (newId < 1)
      throw "ntttt ~ ID cannot be zero or negative ~";

      for (int i = 0; i < accountDatabase.size(); i++)
      if (newId == accountDatabase[i].getId())
      throw "ntttt~ Entered ID is already in use ~";

      id = newId;
      }

      void Account::setBalance(double newBalance){
      if (newBalance < 0)
      throw "ntttt ~ Balance cannot be negative ~";

      balance = newBalance;
      }

      void Account::withdraw(double amount){
      if (amount < 0)
      throw "ntttt ~ Withdrawal amount cannot be negative ~";

      balance -= amount;
      }

      void Account::deposit(double amount){
      if (amount < 0)
      throw "ntttt ~ Amount for deposit cannot be negative ~";

      balance += amount;
      }


      Main



      #include <iostream>
      #include "Account.h"
      #include <string>

      void printMenu(){
      std::cout << "n" << R"(
      Please select one of the following options:

      1. Create an account
      2. Check balance
      3. Withdraw
      4. Deposit
      5. Account summary
      6. Make a transaction
      7. Exit
      )" << "ntttt--> ";
      }

      // get a valid input
      template<typename Type>
      void getInput(Type &value){
      while (true){
      std::cin >> value;
      if (std::cin.fail()){
      std::cin.clear();
      std::cin.ignore(100, 'n');
      std::cout << "nttttt~ Invalid input ~"
      << "ntttt--> Enter again: ";
      }
      else {
      std::cin.ignore();
      return;
      }
      }
      }

      // find account in account database and return index of that account
      int findAccount (int id){
      for (int i = 0; i < Account::accountDatabase.size(); i++)
      if (id == Account::accountDatabase[i].getId()) return i;

      return -1;
      }

      void createAccount (){
      Account newAccount;
      std::cout << "ntttt--> Please enter your name: ";
      std::string name;
      std::cin.ignore();
      std::getline(std::cin, name);
      newAccount.setName(name);
      std::cout << "ntttt--> Please enter your ID: ";
      int id;
      getInput(id);
      newAccount.setID(id);
      std::cout << "ntttt--> Please enter your balance: ";
      double balance;
      getInput(balance);
      newAccount.setBalance(balance);
      // add account to the database
      newAccount.addAccount(newAccount);
      std::cout << "ntttt~ Your account has been successfully created ~n";
      }

      void MenuSelection(){

      int option = 1, account, id;
      while (option != 7){

      try{
      switch (option){
      case 1: createAccount();break;

      // check balance
      case 2:{
      std::cout << "ntttt--> Please enter your ID: ";
      getInput(id);
      account = findAccount(id);
      if (account == -1) std::cout << "ntttt~ ID does not match any in the database ~n";
      else std::cout << "ntttt--> Your balance: " << Account::accountDatabase[account].getBalance();
      } break;

      // withdraw money
      case 3:{
      std::cout << "ntttt--> Enter amount to withdraw: ";
      double withdrawalAmount;
      getInput(withdrawalAmount);
      std::cout << "ntttt--> Please enter your ID: ";
      getInput(id);
      account = findAccount(id);
      if (account == -1) std::cout << "ntttt~ ID does not match any in the database ~n";
      else {
      if (Account::accountDatabase[account].getBalance() >= withdrawalAmount){
      Account::accountDatabase[account].withdraw(withdrawalAmount);
      std::cout << "ntttt~ Amount successfully withdrawn ~n";
      }
      else std::cout << "nttt~ Withdrawal not successful - check the state of balance ~n";
      }
      } break;

      // deposit money
      case 4:{
      std::cout << "ntttt--> Enter amount to deposit: ";
      double depositAmount;
      getInput(depositAmount);
      std::cout << "ntttt--> Please enter your ID: ";
      getInput(id);
      account = findAccount(id);
      if (account == -1) std::cout << "ntttt~ ID does not match any in the database ~n";
      else {
      Account::accountDatabase[account].deposit(depositAmount);
      std::cout << "ntttt-->~ Amount successfully deposited ~n";
      }
      } break;

      // print account summary
      case 5:{
      std::cout << "ntttt--> Please enter your ID: ";
      getInput(id);
      account = findAccount(id);
      if (account == -1) std::cout << "ntttt~ ID does not match any in the database ~n";
      else std::cout << "nntttt~ ACCOUNT SUMMARY ~n"
      << "ntttt--> Name: " << Account::accountDatabase[account].getName()
      << "ntttt--> ID: " << Account::accountDatabase[account].getId()
      << "ntttt--> Balance: " << Account::accountDatabase[account].getBalance() << "n";

      } break;

      // make a transaction
      case 6:{
      std::cout << "ntttt--> Do you wish to withdraw or deposit? (w/d): ";
      char choice;
      std::cin >> choice;
      std::cout << "ntttt--> Enter transaction amount: ";
      double amount;
      getInput(amount);
      std::cout << "ntttt--> Please enter your ID: ";
      getInput(id);
      account = findAccount(id);
      if (account == -1) std::cout << "ntttt~ ID does not match any in the database ~n";
      else {
      std::cout << "ntttt--> Please enter ID of the transaction account: ";
      getInput(id);
      int secondAccount = findAccount(id);
      if (secondAccount == -1) std::cout << "ntttt~ ID does not match any in the database ~n";
      else {
      bool transactionPerformed = false;
      if (tolower(choice) == 'w' && Account::accountDatabase[secondAccount].getBalance() >= amount){
      Account::accountDatabase[secondAccount].withdraw(amount);
      Account::accountDatabase[account].deposit(amount);
      transactionPerformed = true;
      }
      else if (tolower(choice) == 'd' && Account::accountDatabase[account].getBalance() >= amount){
      Account::accountDatabase[secondAccount].deposit(amount);
      Account::accountDatabase[account].withdraw(amount);
      transactionPerformed = true;
      }
      if (!transactionPerformed) std::cout << "ntttt~ Transaction not successful ~n";
      else std::cout << "ntttt~ Transaction successfully completed ~n";
      }
      }
      }
      }
      }
      catch (const char* msg){
      std::cerr << msg;
      }
      printMenu();
      getInput(option);
      while (option < 1 || option > 7){
      std::cout << "ntttt--> Please enter a valid option (1-7): ";
      getInput(option);
      }
      }

      std::cout << R"(
      ########################################################################################################################
      ~ THANK YOU FOR USING OUR SERVICES ~

      ########################################################################################################################
      )";
      }

      int main(){
      std::cout << R"(
      ########################################################################################################################
      ~ W E L C O M E T O O U R B A N K ~

      ########################################################################################################################


      )";
      MenuSelection();
      return 0;
      }






      c++ beginner object-oriented error-handling vectors






      share|improve this question













      share|improve this question











      share|improve this question




      share|improve this question










      asked 4 hours ago









      J.JJ.J

      264




      264






















          1 Answer
          1






          active

          oldest

          votes


















          2












          $begingroup$

          I have a few suggestions:





          • ntttt is everywhere, move it into a function which takes and returns a string, and prepends whatever string it is given with this format - the benefit of this is that if you change your formatting in the future, you only need to do it in one place.

          • Getting the user to enter their ID is a common operation, so put this logic all in one place. i.e.

            std::cout << "ntttt--> Please enter your ID: ";
            getInput(id);
            account = findAccount(id);


            Should be lopped out into its own function, again for the same reason - if the way you want to do it changes, you only need to do it in one place!

          • Move the code within each case block into its own function, e.g for case 2, just make a function called checkBalance which does exactly that. Call it from the case block (similar to how you have done for case 1). The comments already hint at what each block does, but the whole of the switch/case statement is quite a lot of code!

          • The way you look up accounts is a little confusing and potentially inefficient for large numbers of accounts, I would use a map (http://www.cplusplus.com/reference/map/map/) with the key being the ID.


          I hope this is enough to get you on your way, if you give this another stab then I'm happy to take another look!






          share|improve this answer









          $endgroup$














            Your Answer






            StackExchange.ifUsing("editor", function () {
            StackExchange.using("externalEditor", function () {
            StackExchange.using("snippets", function () {
            StackExchange.snippets.init();
            });
            });
            }, "code-snippets");

            StackExchange.ready(function() {
            var channelOptions = {
            tags: "".split(" "),
            id: "196"
            };
            initTagRenderer("".split(" "), "".split(" "), channelOptions);

            StackExchange.using("externalEditor", function() {
            // Have to fire editor after snippets, if snippets enabled
            if (StackExchange.settings.snippets.snippetsEnabled) {
            StackExchange.using("snippets", function() {
            createEditor();
            });
            }
            else {
            createEditor();
            }
            });

            function createEditor() {
            StackExchange.prepareEditor({
            heartbeatType: 'answer',
            autoActivateHeartbeat: false,
            convertImagesToLinks: false,
            noModals: true,
            showLowRepImageUploadWarning: true,
            reputationToPostImages: null,
            bindNavPrevention: true,
            postfix: "",
            imageUploader: {
            brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
            contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
            allowUrls: true
            },
            onDemand: true,
            discardSelector: ".discard-answer"
            ,immediatelyShowMarkdownHelp:true
            });


            }
            });














            draft saved

            draft discarded


















            StackExchange.ready(
            function () {
            StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f217415%2fsimulation-of-a-banking-system-with-an-account-class-in-c%23new-answer', 'question_page');
            }
            );

            Post as a guest















            Required, but never shown

























            1 Answer
            1






            active

            oldest

            votes








            1 Answer
            1






            active

            oldest

            votes









            active

            oldest

            votes






            active

            oldest

            votes









            2












            $begingroup$

            I have a few suggestions:





            • ntttt is everywhere, move it into a function which takes and returns a string, and prepends whatever string it is given with this format - the benefit of this is that if you change your formatting in the future, you only need to do it in one place.

            • Getting the user to enter their ID is a common operation, so put this logic all in one place. i.e.

              std::cout << "ntttt--> Please enter your ID: ";
              getInput(id);
              account = findAccount(id);


              Should be lopped out into its own function, again for the same reason - if the way you want to do it changes, you only need to do it in one place!

            • Move the code within each case block into its own function, e.g for case 2, just make a function called checkBalance which does exactly that. Call it from the case block (similar to how you have done for case 1). The comments already hint at what each block does, but the whole of the switch/case statement is quite a lot of code!

            • The way you look up accounts is a little confusing and potentially inefficient for large numbers of accounts, I would use a map (http://www.cplusplus.com/reference/map/map/) with the key being the ID.


            I hope this is enough to get you on your way, if you give this another stab then I'm happy to take another look!






            share|improve this answer









            $endgroup$


















              2












              $begingroup$

              I have a few suggestions:





              • ntttt is everywhere, move it into a function which takes and returns a string, and prepends whatever string it is given with this format - the benefit of this is that if you change your formatting in the future, you only need to do it in one place.

              • Getting the user to enter their ID is a common operation, so put this logic all in one place. i.e.

                std::cout << "ntttt--> Please enter your ID: ";
                getInput(id);
                account = findAccount(id);


                Should be lopped out into its own function, again for the same reason - if the way you want to do it changes, you only need to do it in one place!

              • Move the code within each case block into its own function, e.g for case 2, just make a function called checkBalance which does exactly that. Call it from the case block (similar to how you have done for case 1). The comments already hint at what each block does, but the whole of the switch/case statement is quite a lot of code!

              • The way you look up accounts is a little confusing and potentially inefficient for large numbers of accounts, I would use a map (http://www.cplusplus.com/reference/map/map/) with the key being the ID.


              I hope this is enough to get you on your way, if you give this another stab then I'm happy to take another look!






              share|improve this answer









              $endgroup$
















                2












                2








                2





                $begingroup$

                I have a few suggestions:





                • ntttt is everywhere, move it into a function which takes and returns a string, and prepends whatever string it is given with this format - the benefit of this is that if you change your formatting in the future, you only need to do it in one place.

                • Getting the user to enter their ID is a common operation, so put this logic all in one place. i.e.

                  std::cout << "ntttt--> Please enter your ID: ";
                  getInput(id);
                  account = findAccount(id);


                  Should be lopped out into its own function, again for the same reason - if the way you want to do it changes, you only need to do it in one place!

                • Move the code within each case block into its own function, e.g for case 2, just make a function called checkBalance which does exactly that. Call it from the case block (similar to how you have done for case 1). The comments already hint at what each block does, but the whole of the switch/case statement is quite a lot of code!

                • The way you look up accounts is a little confusing and potentially inefficient for large numbers of accounts, I would use a map (http://www.cplusplus.com/reference/map/map/) with the key being the ID.


                I hope this is enough to get you on your way, if you give this another stab then I'm happy to take another look!






                share|improve this answer









                $endgroup$



                I have a few suggestions:





                • ntttt is everywhere, move it into a function which takes and returns a string, and prepends whatever string it is given with this format - the benefit of this is that if you change your formatting in the future, you only need to do it in one place.

                • Getting the user to enter their ID is a common operation, so put this logic all in one place. i.e.

                  std::cout << "ntttt--> Please enter your ID: ";
                  getInput(id);
                  account = findAccount(id);


                  Should be lopped out into its own function, again for the same reason - if the way you want to do it changes, you only need to do it in one place!

                • Move the code within each case block into its own function, e.g for case 2, just make a function called checkBalance which does exactly that. Call it from the case block (similar to how you have done for case 1). The comments already hint at what each block does, but the whole of the switch/case statement is quite a lot of code!

                • The way you look up accounts is a little confusing and potentially inefficient for large numbers of accounts, I would use a map (http://www.cplusplus.com/reference/map/map/) with the key being the ID.


                I hope this is enough to get you on your way, if you give this another stab then I'm happy to take another look!







                share|improve this answer












                share|improve this answer



                share|improve this answer










                answered 4 hours ago









                princeprince

                1493




                1493






























                    draft saved

                    draft discarded




















































                    Thanks for contributing an answer to Code Review Stack Exchange!


                    • Please be sure to answer the question. Provide details and share your research!

                    But avoid



                    • Asking for help, clarification, or responding to other answers.

                    • Making statements based on opinion; back them up with references or personal experience.


                    Use MathJax to format equations. MathJax reference.


                    To learn more, see our tips on writing great answers.




                    draft saved


                    draft discarded














                    StackExchange.ready(
                    function () {
                    StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f217415%2fsimulation-of-a-banking-system-with-an-account-class-in-c%23new-answer', 'question_page');
                    }
                    );

                    Post as a guest















                    Required, but never shown





















































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown

































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown







                    Popular posts from this blog

                    El tren de la libertad Índice Antecedentes "Porque yo decido" Desarrollo de la...

                    Puerta de Hutt Referencias Enlaces externos Menú de navegación15°58′00″S 5°42′00″O /...

                    Castillo d'Acher Características Menú de navegación