A faster way to compute the largest prime factor Announcing the arrival of Valued Associate...

Expansion//Explosion and Siren Stormtamer

What *exactly* is electrical current, voltage, and resistance?

How long after the last departure shall the airport stay open for an emergency return?

Where did Arya get these scars?

I preordered a game on my Xbox while on the home screen of my friend's account. Which of us owns the game?

Implementing 3DES algorithm in Java: is my code secure?

Is it OK if I do not take the receipt in Germany?

Is Bran literally the world's memory?

What is this word supposed to be?

Are all CP/M-80 implementations binary compatible?

Can I criticise the more senior developers around me for not writing clean code?

What is /etc/mtab in Linux?

Prove the alternating sum of a decreasing sequence converging to 0 is Cauchy.

What is a 'Key' in computer science?

Justification for leaving new position after a short time

A faster way to compute the largest prime factor

What to do with someone that cheated their way through university and a PhD program?

Does Mathematica have an implementation of the Poisson binomial distribution?

A Paper Record is What I Hamper

Can you stand up from being prone using Skirmisher outside of your turn?

Mistake in years of experience in resume?

Putting Ant-Man on house arrest

Israeli soda type drink

How to keep bees out of canned beverages?



A faster way to compute the largest prime factor



Announcing the arrival of Valued Associate #679: Cesar Manara
Unicorn Meta Zoo #1: Why another podcast?Project Euler #3 - largest prime factorFaster way to determine largest prime factorx64 Assembly - checking for largest prime factorProject Euler #3 (Largest prime factor) in SwiftProject Euler 3: Getting the largest prime factor of a numberVery slow Project Euler Q3 (largest prime factor of a large number)Project Euler 3: Largest prime factorLargest prime factor of a given numberProject Euler 3 - Largest prime factorEuler problem 3: largest prime factor of the numberWork out largest prime factor of a number





.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty,.everyoneloves__bot-mid-leaderboard:empty{ margin-bottom:0;
}







1












$begingroup$


I am self-learning js and came across this problem(#3) from the Euler Project




The prime factors of 13195 are 5, 7, 13 and 29.



What is the largest prime factor of the number 600851475143 ?




Logic:




  • Have an array primes to store all the prime numbers less than number


  • Loop through the odd numbers only below number to check for primes using i



  • Check if i is divisible by any of the elements already in primes.




    • If yes, isPrime = false and break the for loop for j by j=primesLength

    • If not, isPrime = true




  • If isPrime == true then add i to the array primes and check if number%i == 0




    • If number%i == 0% update the value of factor as factor = i



  • Return factor after looping through all the numbers below number



My code:






function problem3(number){

	let factor = 1;

	let primes = [2];	//array to store prime numbers



	for(let i=3; i<number; i=i+2){		//Increment i by 2 to loop through only odd numbers

		let isPrime = true;

		let primesLength= primes.length;



		for(let j=0; j< primesLength; j++){

			if(i%primes[j]==0){

				isPrime = false;

				j=primesLength;	//to break the for loop

			}

		}



		if(isPrime == true){

			primes.push(i);

			if(number%i == 0){

				factor = i;

			}

		}

	}

	return  factor;

}



console.log(problem3(600851475143));





It is working perfectly for small numbers, but is quite very slow for 600851475143. What should I change in this code to make the computation faster?






javascript beginner programming-challenge time-limit-exceeded primes







share|improve this question









New contributor




Eagle is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.







$endgroup$



















    1












    $begingroup$


    I am self-learning js and came across this problem(#3) from the Euler Project




    The prime factors of 13195 are 5, 7, 13 and 29.



    What is the largest prime factor of the number 600851475143 ?




    Logic:




    • Have an array primes to store all the prime numbers less than number


    • Loop through the odd numbers only below number to check for primes using i



    • Check if i is divisible by any of the elements already in primes.




      • If yes, isPrime = false and break the for loop for j by j=primesLength

      • If not, isPrime = true




    • If isPrime == true then add i to the array primes and check if number%i == 0




      • If number%i == 0% update the value of factor as factor = i



    • Return factor after looping through all the numbers below number



    My code:






    function problem3(number){
    
	let factor = 1;
    
	let primes = [2];	//array to store prime numbers
    

    
	for(let i=3; i<number; i=i+2){		//Increment i by 2 to loop through only odd numbers
    
		let isPrime = true;
    
		let primesLength= primes.length;
    

    
		for(let j=0; j< primesLength; j++){
    
			if(i%primes[j]==0){
    
				isPrime = false;
    
				j=primesLength;	//to break the for loop
    
			}
    
		}
    

    
		if(isPrime == true){
    
			primes.push(i);
    
			if(number%i == 0){
    
				factor = i;
    
			}
    
		}
    
	}
    
	return  factor;
    
}
    

    
console.log(problem3(600851475143));





    It is working perfectly for small numbers, but is quite very slow for 600851475143. What should I change in this code to make the computation faster?






    javascript beginner programming-challenge time-limit-exceeded primes







    share|improve this question









    New contributor




    Eagle is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
    Check out our Code of Conduct.







    $endgroup$















      1












      1








      1





      $begingroup$


      I am self-learning js and came across this problem(#3) from the Euler Project




      The prime factors of 13195 are 5, 7, 13 and 29.



      What is the largest prime factor of the number 600851475143 ?




      Logic:




      • Have an array primes to store all the prime numbers less than number


      • Loop through the odd numbers only below number to check for primes using i



      • Check if i is divisible by any of the elements already in primes.




        • If yes, isPrime = false and break the for loop for j by j=primesLength

        • If not, isPrime = true




      • If isPrime == true then add i to the array primes and check if number%i == 0




        • If number%i == 0% update the value of factor as factor = i



      • Return factor after looping through all the numbers below number



      My code:






      function problem3(number){
      
	let factor = 1;
      
	let primes = [2];	//array to store prime numbers
      

      
	for(let i=3; i<number; i=i+2){		//Increment i by 2 to loop through only odd numbers
      
		let isPrime = true;
      
		let primesLength= primes.length;
      

      
		for(let j=0; j< primesLength; j++){
      
			if(i%primes[j]==0){
      
				isPrime = false;
      
				j=primesLength;	//to break the for loop
      
			}
      
		}
      

      
		if(isPrime == true){
      
			primes.push(i);
      
			if(number%i == 0){
      
				factor = i;
      
			}
      
		}
      
	}
      
	return  factor;
      
}
      

      
console.log(problem3(600851475143));





      It is working perfectly for small numbers, but is quite very slow for 600851475143. What should I change in this code to make the computation faster?






      javascript beginner programming-challenge time-limit-exceeded primes







      share|improve this question









      New contributor




      Eagle is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.







      $endgroup$




      I am self-learning js and came across this problem(#3) from the Euler Project




      The prime factors of 13195 are 5, 7, 13 and 29.



      What is the largest prime factor of the number 600851475143 ?




      Logic:




      • Have an array primes to store all the prime numbers less than number


      • Loop through the odd numbers only below number to check for primes using i



      • Check if i is divisible by any of the elements already in primes.




        • If yes, isPrime = false and break the for loop for j by j=primesLength

        • If not, isPrime = true




      • If isPrime == true then add i to the array primes and check if number%i == 0




        • If number%i == 0% update the value of factor as factor = i



      • Return factor after looping through all the numbers below number



      My code:






      function problem3(number){
      
	let factor = 1;
      
	let primes = [2];	//array to store prime numbers
      

      
	for(let i=3; i<number; i=i+2){		//Increment i by 2 to loop through only odd numbers
      
		let isPrime = true;
      
		let primesLength= primes.length;
      

      
		for(let j=0; j< primesLength; j++){
      
			if(i%primes[j]==0){
      
				isPrime = false;
      
				j=primesLength;	//to break the for loop
      
			}
      
		}
      

      
		if(isPrime == true){
      
			primes.push(i);
      
			if(number%i == 0){
      
				factor = i;
      
			}
      
		}
      
	}
      
	return  factor;
      
}
      

      
console.log(problem3(600851475143));





      It is working perfectly for small numbers, but is quite very slow for 600851475143. What should I change in this code to make the computation faster?






      function problem3(number){
      
	let factor = 1;
      
	let primes = [2];	//array to store prime numbers
      

      
	for(let i=3; i<number; i=i+2){		//Increment i by 2 to loop through only odd numbers
      
		let isPrime = true;
      
		let primesLength= primes.length;
      

      
		for(let j=0; j< primesLength; j++){
      
			if(i%primes[j]==0){
      
				isPrime = false;
      
				j=primesLength;	//to break the for loop
      
			}
      
		}
      

      
		if(isPrime == true){
      
			primes.push(i);
      
			if(number%i == 0){
      
				factor = i;
      
			}
      
		}
      
	}
      
	return  factor;
      
}
      

      
console.log(problem3(600851475143));





      function problem3(number){
      
	let factor = 1;
      
	let primes = [2];	//array to store prime numbers
      

      
	for(let i=3; i<number; i=i+2){		//Increment i by 2 to loop through only odd numbers
      
		let isPrime = true;
      
		let primesLength= primes.length;
      

      
		for(let j=0; j< primesLength; j++){
      
			if(i%primes[j]==0){
      
				isPrime = false;
      
				j=primesLength;	//to break the for loop
      
			}
      
		}
      

      
		if(isPrime == true){
      
			primes.push(i);
      
			if(number%i == 0){
      
				factor = i;
      
			}
      
		}
      
	}
      
	return  factor;
      
}
      

      
console.log(problem3(600851475143));





      javascript beginner programming-challenge time-limit-exceeded primes




      javascript beginner programming-challenge time-limit-exceeded primes






      share|improve this question









      New contributor




      Eagle is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.











      share|improve this question









      New contributor




      Eagle is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      share|improve this question




      share|improve this question








      edited 1 hour ago









      200_success

      131k17157422




      131k17157422






      New contributor




      Eagle is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      asked 1 hour ago









      EagleEagle

      1085




      1085




      New contributor




      Eagle is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.





      New contributor





      Eagle is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






      Eagle is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






















          2 Answers
          2






          active

          oldest

          votes


















          3












          $begingroup$

          There are many questions about Project Euler 3 on this site already. The trick is to pick an algorithm that…




          • Reduces n whenever you find a factor, so that you don't need to consider factors anywhere near as large as 600851475143

          • Only finds prime factors, and never composite factors, so that you never need to explicitly test for primality.


          Your algorithm suffers on both criteria: the outer for loop goes all the way up to 600851475143 (which is insane), and you're testing each of those numbers for primality (which is incredibly computationally expensive).






          share|improve this answer









          $endgroup$





















            1












            $begingroup$

            The first problem is that you are trying to find all prime numbers under number. The number of prime numbers under x is approximately x/ln(x) which is around 22153972243.4 for our specific value of x



            This is way too big ! So even if you where capable of obtaining each of these prime numbers in constant time it would take too much time.



            This tells us this approach is most likely unfixable.






            share|improve this answer








            New contributor




            Jorge Fernández is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
            Check out our Code of Conduct.






            $endgroup$














              Your Answer






              StackExchange.ifUsing("editor", function () {
              StackExchange.using("externalEditor", function () {
              StackExchange.using("snippets", function () {
              StackExchange.snippets.init();
              });
              });
              }, "code-snippets");

              StackExchange.ready(function() {
              var channelOptions = {
              tags: "".split(" "),
              id: "196"
              };
              initTagRenderer("".split(" "), "".split(" "), channelOptions);

              StackExchange.using("externalEditor", function() {
              // Have to fire editor after snippets, if snippets enabled
              if (StackExchange.settings.snippets.snippetsEnabled) {
              StackExchange.using("snippets", function() {
              createEditor();
              });
              }
              else {
              createEditor();
              }
              });

              function createEditor() {
              StackExchange.prepareEditor({
              heartbeatType: 'answer',
              autoActivateHeartbeat: false,
              convertImagesToLinks: false,
              noModals: true,
              showLowRepImageUploadWarning: true,
              reputationToPostImages: null,
              bindNavPrevention: true,
              postfix: "",
              imageUploader: {
              brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
              contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
              allowUrls: true
              },
              onDemand: true,
              discardSelector: ".discard-answer"
              ,immediatelyShowMarkdownHelp:true
              });


              }
              });






              Eagle is a new contributor. Be nice, and check out our Code of Conduct.










              draft saved

              draft discarded


















              StackExchange.ready(
              function () {
              StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f219063%2fa-faster-way-to-compute-the-largest-prime-factor%23new-answer', 'question_page');
              }
              );

              Post as a guest















              Required, but never shown

























              2 Answers
              2






              active

              oldest

              votes








              2 Answers
              2






              active

              oldest

              votes









              active

              oldest

              votes






              active

              oldest

              votes









              3












              $begingroup$

              There are many questions about Project Euler 3 on this site already. The trick is to pick an algorithm that…




              • Reduces n whenever you find a factor, so that you don't need to consider factors anywhere near as large as 600851475143

              • Only finds prime factors, and never composite factors, so that you never need to explicitly test for primality.


              Your algorithm suffers on both criteria: the outer for loop goes all the way up to 600851475143 (which is insane), and you're testing each of those numbers for primality (which is incredibly computationally expensive).






              share|improve this answer









              $endgroup$


















                3












                $begingroup$

                There are many questions about Project Euler 3 on this site already. The trick is to pick an algorithm that…




                • Reduces n whenever you find a factor, so that you don't need to consider factors anywhere near as large as 600851475143

                • Only finds prime factors, and never composite factors, so that you never need to explicitly test for primality.


                Your algorithm suffers on both criteria: the outer for loop goes all the way up to 600851475143 (which is insane), and you're testing each of those numbers for primality (which is incredibly computationally expensive).






                share|improve this answer









                $endgroup$
















                  3












                  3








                  3





                  $begingroup$

                  There are many questions about Project Euler 3 on this site already. The trick is to pick an algorithm that…




                  • Reduces n whenever you find a factor, so that you don't need to consider factors anywhere near as large as 600851475143

                  • Only finds prime factors, and never composite factors, so that you never need to explicitly test for primality.


                  Your algorithm suffers on both criteria: the outer for loop goes all the way up to 600851475143 (which is insane), and you're testing each of those numbers for primality (which is incredibly computationally expensive).






                  share|improve this answer









                  $endgroup$



                  There are many questions about Project Euler 3 on this site already. The trick is to pick an algorithm that…




                  • Reduces n whenever you find a factor, so that you don't need to consider factors anywhere near as large as 600851475143

                  • Only finds prime factors, and never composite factors, so that you never need to explicitly test for primality.


                  Your algorithm suffers on both criteria: the outer for loop goes all the way up to 600851475143 (which is insane), and you're testing each of those numbers for primality (which is incredibly computationally expensive).







                  share|improve this answer












                  share|improve this answer



                  share|improve this answer










                  answered 1 hour ago









                  200_success200_success

                  131k17157422




                  131k17157422

























                      1












                      $begingroup$

                      The first problem is that you are trying to find all prime numbers under number. The number of prime numbers under x is approximately x/ln(x) which is around 22153972243.4 for our specific value of x



                      This is way too big ! So even if you where capable of obtaining each of these prime numbers in constant time it would take too much time.



                      This tells us this approach is most likely unfixable.






                      share|improve this answer








                      New contributor




                      Jorge Fernández is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
                      Check out our Code of Conduct.






                      $endgroup$


















                        1












                        $begingroup$

                        The first problem is that you are trying to find all prime numbers under number. The number of prime numbers under x is approximately x/ln(x) which is around 22153972243.4 for our specific value of x



                        This is way too big ! So even if you where capable of obtaining each of these prime numbers in constant time it would take too much time.



                        This tells us this approach is most likely unfixable.






                        share|improve this answer








                        New contributor




                        Jorge Fernández is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
                        Check out our Code of Conduct.






                        $endgroup$
















                          1












                          1








                          1





                          $begingroup$

                          The first problem is that you are trying to find all prime numbers under number. The number of prime numbers under x is approximately x/ln(x) which is around 22153972243.4 for our specific value of x



                          This is way too big ! So even if you where capable of obtaining each of these prime numbers in constant time it would take too much time.



                          This tells us this approach is most likely unfixable.






                          share|improve this answer








                          New contributor




                          Jorge Fernández is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
                          Check out our Code of Conduct.






                          $endgroup$



                          The first problem is that you are trying to find all prime numbers under number. The number of prime numbers under x is approximately x/ln(x) which is around 22153972243.4 for our specific value of x



                          This is way too big ! So even if you where capable of obtaining each of these prime numbers in constant time it would take too much time.



                          This tells us this approach is most likely unfixable.







                          share|improve this answer








                          New contributor




                          Jorge Fernández is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
                          Check out our Code of Conduct.









                          share|improve this answer



                          share|improve this answer






                          New contributor




                          Jorge Fernández is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
                          Check out our Code of Conduct.









                          answered 40 mins ago









                          Jorge FernándezJorge Fernández

                          1645




                          1645




                          New contributor




                          Jorge Fernández is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
                          Check out our Code of Conduct.





                          New contributor





                          Jorge Fernández is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
                          Check out our Code of Conduct.






                          Jorge Fernández is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
                          Check out our Code of Conduct.






















                              Eagle is a new contributor. Be nice, and check out our Code of Conduct.










                              draft saved

                              draft discarded


















                              Eagle is a new contributor. Be nice, and check out our Code of Conduct.













                              Eagle is a new contributor. Be nice, and check out our Code of Conduct.












                              Eagle is a new contributor. Be nice, and check out our Code of Conduct.
















                              Thanks for contributing an answer to Code Review Stack Exchange!


                              • Please be sure to answer the question. Provide details and share your research!

                              But avoid …



                              • Asking for help, clarification, or responding to other answers.

                              • Making statements based on opinion; back them up with references or personal experience.


                              Use MathJax to format equations. MathJax reference.


                              To learn more, see our tips on writing great answers.




                              draft saved


                              draft discarded














                              StackExchange.ready(
                              function () {
                              StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f219063%2fa-faster-way-to-compute-the-largest-prime-factor%23new-answer', 'question_page');
                              }
                              );

                              Post as a guest















                              Required, but never shown





















































                              Required, but never shown














                              Required, but never shown












                              Required, but never shown







                              Required, but never shown

































                              Required, but never shown














                              Required, but never shown












                              Required, but never shown







                              Required, but never shown







                              -

                              Popular posts from this blog

                              El tren de la libertad Índice Antecedentes "Porque yo decido" Desarrollo de la...

                              Image
                              Feminismo en EspañaAborto en EspañaManifestaciones y protestas en EspañaManifestaciones y protestas en 2014España en 2014Historia de las mujeres en España movimiento socialfeministaderechos sexuales y reproductivosmujeresLey del aborto en España1 de febrero2014MadridAlberto Ruíz Gallardónla ley del aborto vigente del 2010AsturiasTertulia Feminista Les ComadresCongreso de DiputadosAlicia MiyaresAna MatoAlberto Ruiz GallardónEdimburgoRomaParísLuxemburgoBuenos AiresGracia QuerejetaÁngeles González-SindeMabel LozanoIcíar BollaínIsabel CoixetGeorgina CisquellaTeresa FontVirginia Yagüe2010José Luis Rodríguez ZapateroCongreso de Diputados19 de diciembre20095 de julio2010Partido PopularTribunal Constitucional201120 de diciembre2013Partido PopularMariano RajoyGijónTertulia Feminista Les ComadresBegoña PiñeroRenfeAlicia MiyaresTertulia Feminista Les Comadres1 de febrero2014Congreso de DiputadosMariano RajoyAlberto Ruiz GallardónAna MatoAsturiasAndalucíaCanariasCataluñaComunidad ValencianaCasti...
                              Read more

                              Castillo d'Acher Características Menú de navegación

                              Image
                              Montañas de los Pirineos de AragónMontañas de la provincia de Huesca msnmSelva de OzaPirineo aragonésEspañabosque Este artículo o sección necesita referencias que aparezcan en una publicación acreditada. Este aviso fue puesto el 11 de agosto de 2011. El pico desde Selva de Oza. El Castillo d' Acher es una cima de 2.384msnm en la zona de la Selva de Oza en la parte occidental del Pirineo aragonés, en España. Debe su nombre a su aspecto de fortaleza que presenta hacia todas sus vertientes. Características En orden ascendente, la cima pasa de un bosque frondoso de tonalidades verde-amarillenta a laderas rojizas. Su cima, que suele presentarse mucha nieve, es un pequeño valle rectangular rodeado en sus cuatro caras por una muralla que le da un aspecto de fortaleza. This page is only for reference, If you need detailed information, please check here
                              Read more

                              Connecting two nodes from the same mother node horizontallyTikZ: What EXACTLY does the the |- notation for...

                              Image
                              Pigeonhole Principle Problem Was Hulk present at this event? Attending a conference where my ex-supervisor and his collaborator are present, should I attend? How did Arya manage to disguise herself? What is the word which sounds like "shtrass"? Does higher resolution in an image imply more bits per pixel? What was the state of the German rail system in 1944? Packet sniffer for MacOS Mojave and above Pressure to defend the relevance of one's area of mathematics Why are there synthetic chemicals in our bodies? Where do they come from? Does the Darkness spell dispel the Color Spray ...
                              Read more