Test whether all array elements are factors of a numberSearching array reports “not found” even though...
Is it legal for company to use my work email to pretend I still work there?
A newer friend of my brother's gave him a load of baseball cards that are supposedly extremely valuable. Is this a scam?
Problem of parity - Can we draw a closed path made up of 20 line segments...
What is the offset in a seaplane's hull?
What do the dots in this tr command do: tr .............A-Z A-ZA-Z <<< "JVPQBOV" (with 13 dots)
What do you call a Matrix-like slowdown and camera movement effect?
How old can references or sources in a thesis be?
Why dont electromagnetic waves interact with each other?
Fencing style for blades that can attack from a distance
"You are your self first supporter", a more proper way to say it
What are these boxed doors outside store fronts in New York?
Is it important to consider tone, melody, and musical form while writing a song?
Has the BBC provided arguments for saying Brexit being cancelled is unlikely?
Why "Having chlorophyll without photosynthesis is actually very dangerous" and "like living with a bomb"?
Font hinting is lost in Chrome-like browsers (for some languages )
How to format long polynomial?
Prove that NP is closed under karp reduction?
How do we improve the relationship with a client software team that performs poorly and is becoming less collaborative?
What typically incentivizes a professor to change jobs to a lower ranking university?
Is this a crack on the carbon frame?
Is it tax fraud for an individual to declare non-taxable revenue as taxable income? (US tax laws)
Do VLANs within a subnet need to have their own subnet for router on a stick?
The use of multiple foreign keys on same column in SQL Server
Why, historically, did Gödel think CH was false?
Test whether all array elements are factors of a number
Searching array reports “not found” even though it's foundPHP: Delete an element from an arrayDeleting array elements in JavaScript - delete vs spliceWhy is setTimeout(fn, 0) sometimes useful?How do I determine whether an array contains a particular value in Java?Determine whether an array contains a valueGet the first element of an arrayGet all unique values in a JavaScript array (remove duplicates)How do I remove a particular element from an array in JavaScript?How can I add new array elements at the beginning of an array in Javascript?How does PHP 'foreach' actually work?
.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty,.everyoneloves__bot-mid-leaderboard:empty{ height:90px;width:728px;box-sizing:border-box;
}
I have the following question:
Write a function that returns true if all integers in an array are factors of a number, and false otherwise.
I tried the code below:
function checkFactors(factors, num) {
for (let i=0; i<factors.length; i++){
let element = factors[i];
console.log(element)
if (num % element !== 0){
return false
}
else {
return true
}
}
}
console.log(checkFactors([1, 2, 3, 8], 12)) //➞ false
My solution returns true which is wrong. I know it's the else statement that's messing it up. But I want to understand why the else statement can't go there.
javascript arrays loops if-statement
add a comment |
I have the following question:
Write a function that returns true if all integers in an array are factors of a number, and false otherwise.
I tried the code below:
function checkFactors(factors, num) {
for (let i=0; i<factors.length; i++){
let element = factors[i];
console.log(element)
if (num % element !== 0){
return false
}
else {
return true
}
}
}
console.log(checkFactors([1, 2, 3, 8], 12)) //➞ false
My solution returns true which is wrong. I know it's the else statement that's messing it up. But I want to understand why the else statement can't go there.
javascript arrays loops if-statement
2
You should get thereturn true
out of the loop ;) and leave thereturn false
inside the loop :) The reason for it is that otherwise your loop really stops after the first checking, returning either true or false, and you want it to return false as soon as something is not a factor. The return true outside of the loop would then indicate that all numbers supplied where factors of the number argument
– Icepickle
13 hours ago
2
FYI, it's not just you, this is one of the most common errors people make when they first start out with programming and loops. :-)
– T.J. Crowder
13 hours ago
1
@t.j.crowder yet we don't have a good dupetarget for it.
– Jonas Wilms
12 hours ago
2
@JonasWilms - Yeah, I bookmarked this one on the basis that there isn't a lot of extraneous stuff, it really is just the earlier return thing. :-)
– T.J. Crowder
12 hours ago
@T.J.Crowder stackoverflow.com/questions/42913798/… is the general dupe I wrote for this class of problems.
– Barmar
7 hours ago
add a comment |
I have the following question:
Write a function that returns true if all integers in an array are factors of a number, and false otherwise.
I tried the code below:
function checkFactors(factors, num) {
for (let i=0; i<factors.length; i++){
let element = factors[i];
console.log(element)
if (num % element !== 0){
return false
}
else {
return true
}
}
}
console.log(checkFactors([1, 2, 3, 8], 12)) //➞ false
My solution returns true which is wrong. I know it's the else statement that's messing it up. But I want to understand why the else statement can't go there.
javascript arrays loops if-statement
I have the following question:
Write a function that returns true if all integers in an array are factors of a number, and false otherwise.
I tried the code below:
function checkFactors(factors, num) {
for (let i=0; i<factors.length; i++){
let element = factors[i];
console.log(element)
if (num % element !== 0){
return false
}
else {
return true
}
}
}
console.log(checkFactors([1, 2, 3, 8], 12)) //➞ false
My solution returns true which is wrong. I know it's the else statement that's messing it up. But I want to understand why the else statement can't go there.
function checkFactors(factors, num) {
for (let i=0; i<factors.length; i++){
let element = factors[i];
console.log(element)
if (num % element !== 0){
return false
}
else {
return true
}
}
}
console.log(checkFactors([1, 2, 3, 8], 12)) //➞ false
function checkFactors(factors, num) {
for (let i=0; i<factors.length; i++){
let element = factors[i];
console.log(element)
if (num % element !== 0){
return false
}
else {
return true
}
}
}
console.log(checkFactors([1, 2, 3, 8], 12)) //➞ false
javascript arrays loops if-statement
javascript arrays loops if-statement
edited 9 hours ago
isanae
2,53711437
2,53711437
asked 13 hours ago
PineNuts0PineNuts0
87431432
87431432
2
You should get thereturn true
out of the loop ;) and leave thereturn false
inside the loop :) The reason for it is that otherwise your loop really stops after the first checking, returning either true or false, and you want it to return false as soon as something is not a factor. The return true outside of the loop would then indicate that all numbers supplied where factors of the number argument
– Icepickle
13 hours ago
2
FYI, it's not just you, this is one of the most common errors people make when they first start out with programming and loops. :-)
– T.J. Crowder
13 hours ago
1
@t.j.crowder yet we don't have a good dupetarget for it.
– Jonas Wilms
12 hours ago
2
@JonasWilms - Yeah, I bookmarked this one on the basis that there isn't a lot of extraneous stuff, it really is just the earlier return thing. :-)
– T.J. Crowder
12 hours ago
@T.J.Crowder stackoverflow.com/questions/42913798/… is the general dupe I wrote for this class of problems.
– Barmar
7 hours ago
add a comment |
2
You should get thereturn true
out of the loop ;) and leave thereturn false
inside the loop :) The reason for it is that otherwise your loop really stops after the first checking, returning either true or false, and you want it to return false as soon as something is not a factor. The return true outside of the loop would then indicate that all numbers supplied where factors of the number argument
– Icepickle
13 hours ago
2
FYI, it's not just you, this is one of the most common errors people make when they first start out with programming and loops. :-)
– T.J. Crowder
13 hours ago
1
@t.j.crowder yet we don't have a good dupetarget for it.
– Jonas Wilms
12 hours ago
2
@JonasWilms - Yeah, I bookmarked this one on the basis that there isn't a lot of extraneous stuff, it really is just the earlier return thing. :-)
– T.J. Crowder
12 hours ago
@T.J.Crowder stackoverflow.com/questions/42913798/… is the general dupe I wrote for this class of problems.
– Barmar
7 hours ago
2
2
You should get the
return true
out of the loop ;) and leave the return false
inside the loop :) The reason for it is that otherwise your loop really stops after the first checking, returning either true or false, and you want it to return false as soon as something is not a factor. The return true outside of the loop would then indicate that all numbers supplied where factors of the number argument– Icepickle
13 hours ago
You should get the
return true
out of the loop ;) and leave the return false
inside the loop :) The reason for it is that otherwise your loop really stops after the first checking, returning either true or false, and you want it to return false as soon as something is not a factor. The return true outside of the loop would then indicate that all numbers supplied where factors of the number argument– Icepickle
13 hours ago
2
2
FYI, it's not just you, this is one of the most common errors people make when they first start out with programming and loops. :-)
– T.J. Crowder
13 hours ago
FYI, it's not just you, this is one of the most common errors people make when they first start out with programming and loops. :-)
– T.J. Crowder
13 hours ago
1
1
@t.j.crowder yet we don't have a good dupetarget for it.
– Jonas Wilms
12 hours ago
@t.j.crowder yet we don't have a good dupetarget for it.
– Jonas Wilms
12 hours ago
2
2
@JonasWilms - Yeah, I bookmarked this one on the basis that there isn't a lot of extraneous stuff, it really is just the earlier return thing. :-)
– T.J. Crowder
12 hours ago
@JonasWilms - Yeah, I bookmarked this one on the basis that there isn't a lot of extraneous stuff, it really is just the earlier return thing. :-)
– T.J. Crowder
12 hours ago
@T.J.Crowder stackoverflow.com/questions/42913798/… is the general dupe I wrote for this class of problems.
– Barmar
7 hours ago
@T.J.Crowder stackoverflow.com/questions/42913798/… is the general dupe I wrote for this class of problems.
– Barmar
7 hours ago
add a comment |
5 Answers
5
active
oldest
votes
Just place return true out of for loop,
If you keep return true
in else part
as soon as any of value which does not satisfies num % element !== 0
your code will return true
which should not happen in this case as you're checking for all the values in array should be factor of given number
Let's understand by 1st example
- On first element in array
1
it will check if conditionnum % element !== 0
which turns out false, so it will go to else condition andreturn true
from function and will not check for rest of values. - So you need to keep
return true
at the end so if any of the value in loop doesn't satisfy the if condition than only control will go toreturn true
function checkFactors(factors, num) {
for (let i=0; i<factors.length; i++){
let element = factors[i];
if (num % element !== 0){
return false
}
}
return true
}
console.log(checkFactors([1, 2, 3, 8], 12)) //➞ false
console.log(checkFactors([1, 2], 2))
In short - In such case where you want all of them must match a condition as a thumb rule you can consider it like
- keep the
failing case
return value inside for loop - keep the
passing case
return value at the end of function
JS have a inbuilt method Array.every for such cases
function checkFactors(factors, num) {
return factors.every(element => num % element === 0);
}
console.log(checkFactors([1, 2, 3, 8], 12));
console.log(checkFactors([1, 2], 2));
add a comment |
You are working in a chocolate store, and your boss tells you to check wether all chocolates (there are chili chocolate, caramel chocolate and coffee chocolate) are delicious. He tells you the following:
Go through all chocolates, and for each chocolate, taste it, if it is fine, tell me that everything is fine, otherwise tell me that something is wrong¹
You start with the first chocolate, which is chili chocolate, it tastes delucious, you go to your boss and tell him that everything is fine. Your boss yells at you because you haven't tasted the caramel chocolate and the coffee chocolate yet.
You realize that your boss actually wanted you to do:
Go through the chocolates, for each chocolate, taste it, if it doesnt taste well tell, tell me immeadiately, otherwise continue until you tasted them all, then return to me and tell me that everything is fine.²
Or in code:
// ¹
function checkChocolates(chocolates) {
for(const chocolate of chocolates) {
if(isTasty(chocolate)) {
return true;
} else {
return false;
}
}
}
// ²
function checkChocolates(chocolates) {
for(const chocolate of chocolates) {
if(isTasty(chocolate)) {
continue; // this could be omitted, as a loop keeps looping nevertheless
} else {
return false;
}
}
return true;
}
As this is a very common task in programming, there is already a shorter way to express this:
if(chocolates.every(isTasty)) {
alert("all chocolates are fine");
} else {
alert("Oh, that doesnt taste good");
}
whereas isTasty
is a function taking a chocolate and returning either true or false.
If you didn't grasp it yet, just try it out! Buy some chocolate, and taste it! If someone tells you "eating choclate isn't learning", respond with "I'm doing rubber duck debugging" and no one can complain :)
1
A tiny quibble - it's "chocolate", not "choclate".
– Wai Ha Lee
12 hours ago
1
@waiHaLee oh, pronounciation tricked me ...
– Jonas Wilms
12 hours ago
add a comment |
Inside the loop the input num
was was tested for divisibility, if the num
was divisible the control was going in the else
block from where the function returned true
.
The loop was not checking for all numbers of the input array it was returning true
when the first number was divisible.
Just use a flag variable to see if all of the elements are divisible by the input number num
, if any one is not divisible the flag
will set to false
and then we can break
out of the loop and return it as there is no point to check the other numbers.
function checkFactors(factors, num) {
let flag = true;
for (let i=0; i<factors.length; i++){
let element = factors[i];
if (num % element !== 0){
flag = false;
break;
}
}
return flag;
}
console.log(checkFactors([1, 2, 3, 8], 12));
console.log(checkFactors([1, 2], 2));
console.log(checkFactors([2, 4, 3, 6, 9], 12));
console.log(checkFactors([3, 5, 2, 6, 9], 15));
console.log(checkFactors([4, 2, 8, 1], 16));
You can also use Array.every
to check the same in a concise way:
function checkFactors(factors, num) {
return factors.every(element => num % element === 0);
}
console.log(checkFactors([1, 2, 3, 8], 12));
console.log(checkFactors([1, 2], 2));
console.log(checkFactors([2, 4, 3, 6, 9], 12));
console.log(checkFactors([3, 5, 2, 6, 9], 15));
console.log(checkFactors([4, 2, 8, 1], 16));
add a comment |
Yes, "else" causing the issue. I removed it and added "return true" outside of for loop.
function checkFactors(factors, num) {
for (let i=0; i<factors.length; i++){
let element = factors[i];
console.log(element)
if (num % element !== 0){
return false
}
}
return true;
}
1
He is looking for an explanation as well though
– Icepickle
12 hours ago
I see Icepickle has explained in the question comments nicely! Jonas Wilms's answer too.
– javapedia.net
12 hours ago
add a comment |
Your code's logic is wrong. You should check all the array's Elements, if all elements satisfy the condition, return true, but if one of them not satisfy the condition, return false immediately. The else means one item satisfy the condition, but not all elements. That's where the problem is.
New contributor
add a comment |
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f55549338%2ftest-whether-all-array-elements-are-factors-of-a-number%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
5 Answers
5
active
oldest
votes
5 Answers
5
active
oldest
votes
active
oldest
votes
active
oldest
votes
Just place return true out of for loop,
If you keep return true
in else part
as soon as any of value which does not satisfies num % element !== 0
your code will return true
which should not happen in this case as you're checking for all the values in array should be factor of given number
Let's understand by 1st example
- On first element in array
1
it will check if conditionnum % element !== 0
which turns out false, so it will go to else condition andreturn true
from function and will not check for rest of values. - So you need to keep
return true
at the end so if any of the value in loop doesn't satisfy the if condition than only control will go toreturn true
function checkFactors(factors, num) {
for (let i=0; i<factors.length; i++){
let element = factors[i];
if (num % element !== 0){
return false
}
}
return true
}
console.log(checkFactors([1, 2, 3, 8], 12)) //➞ false
console.log(checkFactors([1, 2], 2))
In short - In such case where you want all of them must match a condition as a thumb rule you can consider it like
- keep the
failing case
return value inside for loop - keep the
passing case
return value at the end of function
JS have a inbuilt method Array.every for such cases
function checkFactors(factors, num) {
return factors.every(element => num % element === 0);
}
console.log(checkFactors([1, 2, 3, 8], 12));
console.log(checkFactors([1, 2], 2));
add a comment |
Just place return true out of for loop,
If you keep return true
in else part
as soon as any of value which does not satisfies num % element !== 0
your code will return true
which should not happen in this case as you're checking for all the values in array should be factor of given number
Let's understand by 1st example
- On first element in array
1
it will check if conditionnum % element !== 0
which turns out false, so it will go to else condition andreturn true
from function and will not check for rest of values. - So you need to keep
return true
at the end so if any of the value in loop doesn't satisfy the if condition than only control will go toreturn true
function checkFactors(factors, num) {
for (let i=0; i<factors.length; i++){
let element = factors[i];
if (num % element !== 0){
return false
}
}
return true
}
console.log(checkFactors([1, 2, 3, 8], 12)) //➞ false
console.log(checkFactors([1, 2], 2))
In short - In such case where you want all of them must match a condition as a thumb rule you can consider it like
- keep the
failing case
return value inside for loop - keep the
passing case
return value at the end of function
JS have a inbuilt method Array.every for such cases
function checkFactors(factors, num) {
return factors.every(element => num % element === 0);
}
console.log(checkFactors([1, 2, 3, 8], 12));
console.log(checkFactors([1, 2], 2));
add a comment |
Just place return true out of for loop,
If you keep return true
in else part
as soon as any of value which does not satisfies num % element !== 0
your code will return true
which should not happen in this case as you're checking for all the values in array should be factor of given number
Let's understand by 1st example
- On first element in array
1
it will check if conditionnum % element !== 0
which turns out false, so it will go to else condition andreturn true
from function and will not check for rest of values. - So you need to keep
return true
at the end so if any of the value in loop doesn't satisfy the if condition than only control will go toreturn true
function checkFactors(factors, num) {
for (let i=0; i<factors.length; i++){
let element = factors[i];
if (num % element !== 0){
return false
}
}
return true
}
console.log(checkFactors([1, 2, 3, 8], 12)) //➞ false
console.log(checkFactors([1, 2], 2))
In short - In such case where you want all of them must match a condition as a thumb rule you can consider it like
- keep the
failing case
return value inside for loop - keep the
passing case
return value at the end of function
JS have a inbuilt method Array.every for such cases
function checkFactors(factors, num) {
return factors.every(element => num % element === 0);
}
console.log(checkFactors([1, 2, 3, 8], 12));
console.log(checkFactors([1, 2], 2));
Just place return true out of for loop,
If you keep return true
in else part
as soon as any of value which does not satisfies num % element !== 0
your code will return true
which should not happen in this case as you're checking for all the values in array should be factor of given number
Let's understand by 1st example
- On first element in array
1
it will check if conditionnum % element !== 0
which turns out false, so it will go to else condition andreturn true
from function and will not check for rest of values. - So you need to keep
return true
at the end so if any of the value in loop doesn't satisfy the if condition than only control will go toreturn true
function checkFactors(factors, num) {
for (let i=0; i<factors.length; i++){
let element = factors[i];
if (num % element !== 0){
return false
}
}
return true
}
console.log(checkFactors([1, 2, 3, 8], 12)) //➞ false
console.log(checkFactors([1, 2], 2))
In short - In such case where you want all of them must match a condition as a thumb rule you can consider it like
- keep the
failing case
return value inside for loop - keep the
passing case
return value at the end of function
JS have a inbuilt method Array.every for such cases
function checkFactors(factors, num) {
return factors.every(element => num % element === 0);
}
console.log(checkFactors([1, 2, 3, 8], 12));
console.log(checkFactors([1, 2], 2));
function checkFactors(factors, num) {
for (let i=0; i<factors.length; i++){
let element = factors[i];
if (num % element !== 0){
return false
}
}
return true
}
console.log(checkFactors([1, 2, 3, 8], 12)) //➞ false
console.log(checkFactors([1, 2], 2))
function checkFactors(factors, num) {
for (let i=0; i<factors.length; i++){
let element = factors[i];
if (num % element !== 0){
return false
}
}
return true
}
console.log(checkFactors([1, 2, 3, 8], 12)) //➞ false
console.log(checkFactors([1, 2], 2))
function checkFactors(factors, num) {
return factors.every(element => num % element === 0);
}
console.log(checkFactors([1, 2, 3, 8], 12));
console.log(checkFactors([1, 2], 2));
function checkFactors(factors, num) {
return factors.every(element => num % element === 0);
}
console.log(checkFactors([1, 2, 3, 8], 12));
console.log(checkFactors([1, 2], 2));
edited 9 hours ago
answered 13 hours ago
Code ManiacCode Maniac
11.5k2833
11.5k2833
add a comment |
add a comment |
You are working in a chocolate store, and your boss tells you to check wether all chocolates (there are chili chocolate, caramel chocolate and coffee chocolate) are delicious. He tells you the following:
Go through all chocolates, and for each chocolate, taste it, if it is fine, tell me that everything is fine, otherwise tell me that something is wrong¹
You start with the first chocolate, which is chili chocolate, it tastes delucious, you go to your boss and tell him that everything is fine. Your boss yells at you because you haven't tasted the caramel chocolate and the coffee chocolate yet.
You realize that your boss actually wanted you to do:
Go through the chocolates, for each chocolate, taste it, if it doesnt taste well tell, tell me immeadiately, otherwise continue until you tasted them all, then return to me and tell me that everything is fine.²
Or in code:
// ¹
function checkChocolates(chocolates) {
for(const chocolate of chocolates) {
if(isTasty(chocolate)) {
return true;
} else {
return false;
}
}
}
// ²
function checkChocolates(chocolates) {
for(const chocolate of chocolates) {
if(isTasty(chocolate)) {
continue; // this could be omitted, as a loop keeps looping nevertheless
} else {
return false;
}
}
return true;
}
As this is a very common task in programming, there is already a shorter way to express this:
if(chocolates.every(isTasty)) {
alert("all chocolates are fine");
} else {
alert("Oh, that doesnt taste good");
}
whereas isTasty
is a function taking a chocolate and returning either true or false.
If you didn't grasp it yet, just try it out! Buy some chocolate, and taste it! If someone tells you "eating choclate isn't learning", respond with "I'm doing rubber duck debugging" and no one can complain :)
1
A tiny quibble - it's "chocolate", not "choclate".
– Wai Ha Lee
12 hours ago
1
@waiHaLee oh, pronounciation tricked me ...
– Jonas Wilms
12 hours ago
add a comment |
You are working in a chocolate store, and your boss tells you to check wether all chocolates (there are chili chocolate, caramel chocolate and coffee chocolate) are delicious. He tells you the following:
Go through all chocolates, and for each chocolate, taste it, if it is fine, tell me that everything is fine, otherwise tell me that something is wrong¹
You start with the first chocolate, which is chili chocolate, it tastes delucious, you go to your boss and tell him that everything is fine. Your boss yells at you because you haven't tasted the caramel chocolate and the coffee chocolate yet.
You realize that your boss actually wanted you to do:
Go through the chocolates, for each chocolate, taste it, if it doesnt taste well tell, tell me immeadiately, otherwise continue until you tasted them all, then return to me and tell me that everything is fine.²
Or in code:
// ¹
function checkChocolates(chocolates) {
for(const chocolate of chocolates) {
if(isTasty(chocolate)) {
return true;
} else {
return false;
}
}
}
// ²
function checkChocolates(chocolates) {
for(const chocolate of chocolates) {
if(isTasty(chocolate)) {
continue; // this could be omitted, as a loop keeps looping nevertheless
} else {
return false;
}
}
return true;
}
As this is a very common task in programming, there is already a shorter way to express this:
if(chocolates.every(isTasty)) {
alert("all chocolates are fine");
} else {
alert("Oh, that doesnt taste good");
}
whereas isTasty
is a function taking a chocolate and returning either true or false.
If you didn't grasp it yet, just try it out! Buy some chocolate, and taste it! If someone tells you "eating choclate isn't learning", respond with "I'm doing rubber duck debugging" and no one can complain :)
1
A tiny quibble - it's "chocolate", not "choclate".
– Wai Ha Lee
12 hours ago
1
@waiHaLee oh, pronounciation tricked me ...
– Jonas Wilms
12 hours ago
add a comment |
You are working in a chocolate store, and your boss tells you to check wether all chocolates (there are chili chocolate, caramel chocolate and coffee chocolate) are delicious. He tells you the following:
Go through all chocolates, and for each chocolate, taste it, if it is fine, tell me that everything is fine, otherwise tell me that something is wrong¹
You start with the first chocolate, which is chili chocolate, it tastes delucious, you go to your boss and tell him that everything is fine. Your boss yells at you because you haven't tasted the caramel chocolate and the coffee chocolate yet.
You realize that your boss actually wanted you to do:
Go through the chocolates, for each chocolate, taste it, if it doesnt taste well tell, tell me immeadiately, otherwise continue until you tasted them all, then return to me and tell me that everything is fine.²
Or in code:
// ¹
function checkChocolates(chocolates) {
for(const chocolate of chocolates) {
if(isTasty(chocolate)) {
return true;
} else {
return false;
}
}
}
// ²
function checkChocolates(chocolates) {
for(const chocolate of chocolates) {
if(isTasty(chocolate)) {
continue; // this could be omitted, as a loop keeps looping nevertheless
} else {
return false;
}
}
return true;
}
As this is a very common task in programming, there is already a shorter way to express this:
if(chocolates.every(isTasty)) {
alert("all chocolates are fine");
} else {
alert("Oh, that doesnt taste good");
}
whereas isTasty
is a function taking a chocolate and returning either true or false.
If you didn't grasp it yet, just try it out! Buy some chocolate, and taste it! If someone tells you "eating choclate isn't learning", respond with "I'm doing rubber duck debugging" and no one can complain :)
You are working in a chocolate store, and your boss tells you to check wether all chocolates (there are chili chocolate, caramel chocolate and coffee chocolate) are delicious. He tells you the following:
Go through all chocolates, and for each chocolate, taste it, if it is fine, tell me that everything is fine, otherwise tell me that something is wrong¹
You start with the first chocolate, which is chili chocolate, it tastes delucious, you go to your boss and tell him that everything is fine. Your boss yells at you because you haven't tasted the caramel chocolate and the coffee chocolate yet.
You realize that your boss actually wanted you to do:
Go through the chocolates, for each chocolate, taste it, if it doesnt taste well tell, tell me immeadiately, otherwise continue until you tasted them all, then return to me and tell me that everything is fine.²
Or in code:
// ¹
function checkChocolates(chocolates) {
for(const chocolate of chocolates) {
if(isTasty(chocolate)) {
return true;
} else {
return false;
}
}
}
// ²
function checkChocolates(chocolates) {
for(const chocolate of chocolates) {
if(isTasty(chocolate)) {
continue; // this could be omitted, as a loop keeps looping nevertheless
} else {
return false;
}
}
return true;
}
As this is a very common task in programming, there is already a shorter way to express this:
if(chocolates.every(isTasty)) {
alert("all chocolates are fine");
} else {
alert("Oh, that doesnt taste good");
}
whereas isTasty
is a function taking a chocolate and returning either true or false.
If you didn't grasp it yet, just try it out! Buy some chocolate, and taste it! If someone tells you "eating choclate isn't learning", respond with "I'm doing rubber duck debugging" and no one can complain :)
edited 12 hours ago
answered 12 hours ago
Jonas WilmsJonas Wilms
65.4k53660
65.4k53660
1
A tiny quibble - it's "chocolate", not "choclate".
– Wai Ha Lee
12 hours ago
1
@waiHaLee oh, pronounciation tricked me ...
– Jonas Wilms
12 hours ago
add a comment |
1
A tiny quibble - it's "chocolate", not "choclate".
– Wai Ha Lee
12 hours ago
1
@waiHaLee oh, pronounciation tricked me ...
– Jonas Wilms
12 hours ago
1
1
A tiny quibble - it's "chocolate", not "choclate".
– Wai Ha Lee
12 hours ago
A tiny quibble - it's "chocolate", not "choclate".
– Wai Ha Lee
12 hours ago
1
1
@waiHaLee oh, pronounciation tricked me ...
– Jonas Wilms
12 hours ago
@waiHaLee oh, pronounciation tricked me ...
– Jonas Wilms
12 hours ago
add a comment |
Inside the loop the input num
was was tested for divisibility, if the num
was divisible the control was going in the else
block from where the function returned true
.
The loop was not checking for all numbers of the input array it was returning true
when the first number was divisible.
Just use a flag variable to see if all of the elements are divisible by the input number num
, if any one is not divisible the flag
will set to false
and then we can break
out of the loop and return it as there is no point to check the other numbers.
function checkFactors(factors, num) {
let flag = true;
for (let i=0; i<factors.length; i++){
let element = factors[i];
if (num % element !== 0){
flag = false;
break;
}
}
return flag;
}
console.log(checkFactors([1, 2, 3, 8], 12));
console.log(checkFactors([1, 2], 2));
console.log(checkFactors([2, 4, 3, 6, 9], 12));
console.log(checkFactors([3, 5, 2, 6, 9], 15));
console.log(checkFactors([4, 2, 8, 1], 16));
You can also use Array.every
to check the same in a concise way:
function checkFactors(factors, num) {
return factors.every(element => num % element === 0);
}
console.log(checkFactors([1, 2, 3, 8], 12));
console.log(checkFactors([1, 2], 2));
console.log(checkFactors([2, 4, 3, 6, 9], 12));
console.log(checkFactors([3, 5, 2, 6, 9], 15));
console.log(checkFactors([4, 2, 8, 1], 16));
add a comment |
Inside the loop the input num
was was tested for divisibility, if the num
was divisible the control was going in the else
block from where the function returned true
.
The loop was not checking for all numbers of the input array it was returning true
when the first number was divisible.
Just use a flag variable to see if all of the elements are divisible by the input number num
, if any one is not divisible the flag
will set to false
and then we can break
out of the loop and return it as there is no point to check the other numbers.
function checkFactors(factors, num) {
let flag = true;
for (let i=0; i<factors.length; i++){
let element = factors[i];
if (num % element !== 0){
flag = false;
break;
}
}
return flag;
}
console.log(checkFactors([1, 2, 3, 8], 12));
console.log(checkFactors([1, 2], 2));
console.log(checkFactors([2, 4, 3, 6, 9], 12));
console.log(checkFactors([3, 5, 2, 6, 9], 15));
console.log(checkFactors([4, 2, 8, 1], 16));
You can also use Array.every
to check the same in a concise way:
function checkFactors(factors, num) {
return factors.every(element => num % element === 0);
}
console.log(checkFactors([1, 2, 3, 8], 12));
console.log(checkFactors([1, 2], 2));
console.log(checkFactors([2, 4, 3, 6, 9], 12));
console.log(checkFactors([3, 5, 2, 6, 9], 15));
console.log(checkFactors([4, 2, 8, 1], 16));
add a comment |
Inside the loop the input num
was was tested for divisibility, if the num
was divisible the control was going in the else
block from where the function returned true
.
The loop was not checking for all numbers of the input array it was returning true
when the first number was divisible.
Just use a flag variable to see if all of the elements are divisible by the input number num
, if any one is not divisible the flag
will set to false
and then we can break
out of the loop and return it as there is no point to check the other numbers.
function checkFactors(factors, num) {
let flag = true;
for (let i=0; i<factors.length; i++){
let element = factors[i];
if (num % element !== 0){
flag = false;
break;
}
}
return flag;
}
console.log(checkFactors([1, 2, 3, 8], 12));
console.log(checkFactors([1, 2], 2));
console.log(checkFactors([2, 4, 3, 6, 9], 12));
console.log(checkFactors([3, 5, 2, 6, 9], 15));
console.log(checkFactors([4, 2, 8, 1], 16));
You can also use Array.every
to check the same in a concise way:
function checkFactors(factors, num) {
return factors.every(element => num % element === 0);
}
console.log(checkFactors([1, 2, 3, 8], 12));
console.log(checkFactors([1, 2], 2));
console.log(checkFactors([2, 4, 3, 6, 9], 12));
console.log(checkFactors([3, 5, 2, 6, 9], 15));
console.log(checkFactors([4, 2, 8, 1], 16));
Inside the loop the input num
was was tested for divisibility, if the num
was divisible the control was going in the else
block from where the function returned true
.
The loop was not checking for all numbers of the input array it was returning true
when the first number was divisible.
Just use a flag variable to see if all of the elements are divisible by the input number num
, if any one is not divisible the flag
will set to false
and then we can break
out of the loop and return it as there is no point to check the other numbers.
function checkFactors(factors, num) {
let flag = true;
for (let i=0; i<factors.length; i++){
let element = factors[i];
if (num % element !== 0){
flag = false;
break;
}
}
return flag;
}
console.log(checkFactors([1, 2, 3, 8], 12));
console.log(checkFactors([1, 2], 2));
console.log(checkFactors([2, 4, 3, 6, 9], 12));
console.log(checkFactors([3, 5, 2, 6, 9], 15));
console.log(checkFactors([4, 2, 8, 1], 16));
You can also use Array.every
to check the same in a concise way:
function checkFactors(factors, num) {
return factors.every(element => num % element === 0);
}
console.log(checkFactors([1, 2, 3, 8], 12));
console.log(checkFactors([1, 2], 2));
console.log(checkFactors([2, 4, 3, 6, 9], 12));
console.log(checkFactors([3, 5, 2, 6, 9], 15));
console.log(checkFactors([4, 2, 8, 1], 16));
function checkFactors(factors, num) {
let flag = true;
for (let i=0; i<factors.length; i++){
let element = factors[i];
if (num % element !== 0){
flag = false;
break;
}
}
return flag;
}
console.log(checkFactors([1, 2, 3, 8], 12));
console.log(checkFactors([1, 2], 2));
console.log(checkFactors([2, 4, 3, 6, 9], 12));
console.log(checkFactors([3, 5, 2, 6, 9], 15));
console.log(checkFactors([4, 2, 8, 1], 16));
function checkFactors(factors, num) {
let flag = true;
for (let i=0; i<factors.length; i++){
let element = factors[i];
if (num % element !== 0){
flag = false;
break;
}
}
return flag;
}
console.log(checkFactors([1, 2, 3, 8], 12));
console.log(checkFactors([1, 2], 2));
console.log(checkFactors([2, 4, 3, 6, 9], 12));
console.log(checkFactors([3, 5, 2, 6, 9], 15));
console.log(checkFactors([4, 2, 8, 1], 16));
function checkFactors(factors, num) {
return factors.every(element => num % element === 0);
}
console.log(checkFactors([1, 2, 3, 8], 12));
console.log(checkFactors([1, 2], 2));
console.log(checkFactors([2, 4, 3, 6, 9], 12));
console.log(checkFactors([3, 5, 2, 6, 9], 15));
console.log(checkFactors([4, 2, 8, 1], 16));
function checkFactors(factors, num) {
return factors.every(element => num % element === 0);
}
console.log(checkFactors([1, 2, 3, 8], 12));
console.log(checkFactors([1, 2], 2));
console.log(checkFactors([2, 4, 3, 6, 9], 12));
console.log(checkFactors([3, 5, 2, 6, 9], 15));
console.log(checkFactors([4, 2, 8, 1], 16));
edited 12 hours ago
answered 12 hours ago
Amardeep BhowmickAmardeep Bhowmick
5,38321128
5,38321128
add a comment |
add a comment |
Yes, "else" causing the issue. I removed it and added "return true" outside of for loop.
function checkFactors(factors, num) {
for (let i=0; i<factors.length; i++){
let element = factors[i];
console.log(element)
if (num % element !== 0){
return false
}
}
return true;
}
1
He is looking for an explanation as well though
– Icepickle
12 hours ago
I see Icepickle has explained in the question comments nicely! Jonas Wilms's answer too.
– javapedia.net
12 hours ago
add a comment |
Yes, "else" causing the issue. I removed it and added "return true" outside of for loop.
function checkFactors(factors, num) {
for (let i=0; i<factors.length; i++){
let element = factors[i];
console.log(element)
if (num % element !== 0){
return false
}
}
return true;
}
1
He is looking for an explanation as well though
– Icepickle
12 hours ago
I see Icepickle has explained in the question comments nicely! Jonas Wilms's answer too.
– javapedia.net
12 hours ago
add a comment |
Yes, "else" causing the issue. I removed it and added "return true" outside of for loop.
function checkFactors(factors, num) {
for (let i=0; i<factors.length; i++){
let element = factors[i];
console.log(element)
if (num % element !== 0){
return false
}
}
return true;
}
Yes, "else" causing the issue. I removed it and added "return true" outside of for loop.
function checkFactors(factors, num) {
for (let i=0; i<factors.length; i++){
let element = factors[i];
console.log(element)
if (num % element !== 0){
return false
}
}
return true;
}
answered 13 hours ago
javapedia.netjavapedia.net
582311
582311
1
He is looking for an explanation as well though
– Icepickle
12 hours ago
I see Icepickle has explained in the question comments nicely! Jonas Wilms's answer too.
– javapedia.net
12 hours ago
add a comment |
1
He is looking for an explanation as well though
– Icepickle
12 hours ago
I see Icepickle has explained in the question comments nicely! Jonas Wilms's answer too.
– javapedia.net
12 hours ago
1
1
He is looking for an explanation as well though
– Icepickle
12 hours ago
He is looking for an explanation as well though
– Icepickle
12 hours ago
I see Icepickle has explained in the question comments nicely! Jonas Wilms's answer too.
– javapedia.net
12 hours ago
I see Icepickle has explained in the question comments nicely! Jonas Wilms's answer too.
– javapedia.net
12 hours ago
add a comment |
Your code's logic is wrong. You should check all the array's Elements, if all elements satisfy the condition, return true, but if one of them not satisfy the condition, return false immediately. The else means one item satisfy the condition, but not all elements. That's where the problem is.
New contributor
add a comment |
Your code's logic is wrong. You should check all the array's Elements, if all elements satisfy the condition, return true, but if one of them not satisfy the condition, return false immediately. The else means one item satisfy the condition, but not all elements. That's where the problem is.
New contributor
add a comment |
Your code's logic is wrong. You should check all the array's Elements, if all elements satisfy the condition, return true, but if one of them not satisfy the condition, return false immediately. The else means one item satisfy the condition, but not all elements. That's where the problem is.
New contributor
Your code's logic is wrong. You should check all the array's Elements, if all elements satisfy the condition, return true, but if one of them not satisfy the condition, return false immediately. The else means one item satisfy the condition, but not all elements. That's where the problem is.
New contributor
New contributor
answered 12 hours ago
W.BrightW.Bright
133
133
New contributor
New contributor
add a comment |
add a comment |
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f55549338%2ftest-whether-all-array-elements-are-factors-of-a-number%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
2
You should get the
return true
out of the loop ;) and leave thereturn false
inside the loop :) The reason for it is that otherwise your loop really stops after the first checking, returning either true or false, and you want it to return false as soon as something is not a factor. The return true outside of the loop would then indicate that all numbers supplied where factors of the number argument– Icepickle
13 hours ago
2
FYI, it's not just you, this is one of the most common errors people make when they first start out with programming and loops. :-)
– T.J. Crowder
13 hours ago
1
@t.j.crowder yet we don't have a good dupetarget for it.
– Jonas Wilms
12 hours ago
2
@JonasWilms - Yeah, I bookmarked this one on the basis that there isn't a lot of extraneous stuff, it really is just the earlier return thing. :-)
– T.J. Crowder
12 hours ago
@T.J.Crowder stackoverflow.com/questions/42913798/… is the general dupe I wrote for this class of problems.
– Barmar
7 hours ago